Au-Miner opened a new pull request, #28220:
URL: https://github.com/apache/flink/pull/28220
## What is the purpose of the change
`PlannerModule` extracted the `flink-table-planner` JAR into the JVM default
temp directory (e.g. `/tmp`) regardless of the `io.tmp.dirs` value configured
in `flink-conf.yaml`. This fix makes the loader honor the configured directory.
## Brief change log
- Replace `new Configuration()` with
`GlobalConfiguration.loadConfiguration()` in `PlannerModule`'s constructor so
the loaded `flink-conf.yaml` is used when resolving the temp directory.
- Extract the temp-directory resolution into a package-private
`PlannerModule#resolveTmpDirectory(Configuration)` (annotated
`@VisibleForTesting`) to keep the constructor focused and to make the logic
unit-testable.
## Verifying this change
Added `PlannerModuleTest` with two cases:
`resolveTmpDirectoryHonorsIoTmpDirsFromYaml` writes a `config.yaml` with a
custom `io.tmp.dirs`, loads it via
`GlobalConfiguration.loadConfiguration(configDir, null)`, and asserts
`PlannerModule.resolveTmpDirectory(...)` returns the configured path;
`resolveTmpDirectoryFallsBackToDefaultWhenIoTmpDirsUnset` asserts the fallback
to `CoreOptions.TMP_DIRS` default for an empty configuration.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
