PavelZeger opened a new pull request, #1116:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1116

   ## What is the purpose of the change
   
   This pull request fixes several LOG.warn / LOG.error call sites across the 
operator and autoscaler that swallow the caught exception
   by formatting only a message string, without passing the Throwable to SLF4J. 
As a result, stack traces of these caught failures are
   lost, making it harder to diagnose issues in production. The change passes 
the exception as the last argument so SLF4J logs the
   full stack trace alongside the message.
   
   ## Brief change log
   
   - MemoryTuning#tune — pass IllegalConfigurationException to the warn log 
when aborting memory tuning due to invalid memory
   configuration.
   - KubernetesAutoScalerStateStore#decompress — pass the caught Exception when 
falling back to treating scaling data as uncompressed.
   - FlinkConfigManager — pass NumberFormatException / IllegalArgumentException 
when failing to parse the Flink version in a config
   key.
   - StateSnapshotReconciler — pass the caught exception when failing to 
dispose a savepoint for a deployment.
   - IngressUtils#isVersionAtLeast — pass IllegalArgumentException when failing 
to parse the Kubernetes server version.
   - AggregatedMetric.java — minor import reordering (no behavior change).
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage. It 
only enriches existing log statements with the caught
   exception; no control flow, public API, or behavior is changed.
   
   Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changes to the CustomResourceDescriptors: no
   - Core observer or reconciler logic that is regularly executed: no 
(logging-only changes inside catch blocks; one site is in
   StateSnapshotReconciler, but only the catch-branch log message is altered)
   
   Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to