jubins commented on PR #28202: URL: https://github.com/apache/flink/pull/28202#issuecomment-4512473585
> This change looks reasonable. It now enables a server flow, that could not be called before . Is this server side code path tested somewhere? Or do we need to add an integration style test. @davidradl thanks for your review! For Job endpoint, the server flow is already tested here: [JobExceptionsHandlerTest](https://github.com/apache/flink/blob/8ffb4994f725836cf14b0160ef21227b69762261/flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandlerTest.java#L567). For Application endpoint, while checking I noticed [ApplicationExceptionsHandler](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/application/ApplicationExceptionsHandler.java) doesn't read `maxExceptions` at all today, and [ApplicationExceptionsHeaders](https://github.com/apache/flink/blob/8ffb4994f725836cf14b0160ef21227b69762261/flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/application/ApplicationExceptionsHeaders.java) is typed on ApplicationMessageParameters (parent), so ApplicationExceptionsMessageParameters is orphaned scaffolding from FLINK-38977, and the server would silently discard the param. Since that's wider than client-side accessibility, I'll scope this PR to the job endpoint and file a follow-up JIRA for the application-side wiring + field exposure. Happy to expand here instead if you'd prefer one PR, just let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
