autophagy commented on code in PR #28212: URL: https://github.com/apache/flink/pull/28212#discussion_r3288190876
########## flink-table/flink-table-test-utils/src/main/java/org/apache/flink/table/runtime/functions/ListViewStateConverter.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.functions; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.dataview.ListView; +import org.apache.flink.table.data.ArrayData; +import org.apache.flink.table.data.GenericArrayData; +import org.apache.flink.table.data.conversion.DataStructureConverter; +import org.apache.flink.table.types.logical.ArrayType; + +import java.util.ArrayList; +import java.util.List; + +/** + * Converter for ListView state. + * + * <p>Converts between external ListView objects and internal ArrayData representation. + */ +@Internal +class ListViewStateConverter implements StateConverter { Review Comment: Yeah, my initial implementation of these classes tried to use generics more but I ran into problems, mostly around needing to mark the internal/external types as generic, but then needing a wildcard for the state converter storage (like `Map<String, StateConverter<?, ?>>`) and then needing to cast everywhere anyway. It basically moved the unchecked casting from within the converter classes up into the manager without any real type safety :( ########## flink-table/flink-table-test-utils/src/main/java/org/apache/flink/table/runtime/functions/ListViewStateConverter.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.functions; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.dataview.ListView; +import org.apache.flink.table.data.ArrayData; +import org.apache.flink.table.data.GenericArrayData; +import org.apache.flink.table.data.conversion.DataStructureConverter; +import org.apache.flink.table.types.logical.ArrayType; + +import java.util.ArrayList; +import java.util.List; + +/** + * Converter for ListView state. + * + * <p>Converts between external ListView objects and internal ArrayData representation. + */ +@Internal +class ListViewStateConverter implements StateConverter { Review Comment: Yeah, my initial implementation of these classes tried to use generics more but I ran into problems, mostly around needing to mark the internal/external types as generic, but then needing a wildcard for the state converter storage (like `Map<String, StateConverter<?, ?>>`) and then needing to cast everywhere anyway. It basically moved the unchecked casting from within the converter classes up into the manager without any real type safety 😞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
