featzhang commented on PR #67: URL: https://github.com/apache/flink-connector-mongodb/pull/67#issuecomment-4527162681
Hi @Savonitar — sorry, I genuinely didn't see #64 before I opened this. Just looked through it and yeah, the PAGINATION docs, the at-least-once typo, the ZH `setOrderedWrites` / `setBypassDocumentValidation` block and the en sink numbering are all there in yours, plus a few extra fixes in the table doc that mine doesn't touch. Pretty much fully covered. The only two small bits I had on top of #64: - the `MongoDB Source` → `MongoDB Sink` typo in the **zh** datastream doc (under `### 配置项` of the Sink section — line `Flink 的 MongoDB Source 可以通过 MongoSink.<InputType>builder() 构造器构建。`) - the two missing imports (`MemorySize`, `PartitionStrategy`) in the datastream code samples — those classes are referenced just below but never imported Happy to drop those in as a follow-up after #64 lands so we don't fragment the review. Will close this once #64 merges and update FLINK-39643 to point at FLINK-39400. Thanks for flagging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
