ferenc-csaky commented on code in PR #247: URL: https://github.com/apache/flink-connector-aws/pull/247#discussion_r3294244151
########## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/fanout/FanOutKinesisShardSplitReader.java: ########## Review Comment: Was not touched by this change, but I think we should add `subscription.close()` after this remove, cause in the `close()` method if this class, it will only close the subscriptions that map still contains. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
