ferenc-csaky commented on code in PR #234:
URL:
https://github.com/apache/flink-connector-aws/pull/234#discussion_r3294355941
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/RowDataToAttributeValueConverter.java:
##########
@@ -84,18 +91,63 @@ private StaticTableSchema.Builder<RowData> addAttribute(
DataTypes.Field field,
RowData.FieldGetter fieldGetter) {
+ EnhancedType<Object> enhancedType =
getEnhancedType(field.getDataType());
return builder.addAttribute(
- getEnhancedType(field.getDataType()),
- a ->
- a.name(field.getName())
- .getter(
- rowData ->
-
DataStructureConverters.getConverter(
-
field.getDataType())
- .toExternalOrNull(
-
fieldGetter.getFieldOrNull(
-
rowData)))
- .setter(((rowData, t) -> {})));
+ enhancedType,
+ a -> {
+ a.name(field.getName())
+ .getter(
+ rowData ->
+
DataStructureConverters.getConverter(
+
field.getDataType())
+ .toExternalOrNull(
+
fieldGetter.getFieldOrNull(rowData)))
+ .setter(((rowData, t) -> {}));
+ buildRowAttributeConverter(field.getDataType())
+ .ifPresent(a::attributeConverter);
+ });
+ }
+
+ private java.util.Optional<AttributeConverter>
buildRowAttributeConverter(DataType dataType) {
Review Comment:
Let's add a qualified import for `Optional`.
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/RowDataToAttributeValueConverter.java:
##########
@@ -84,18 +91,63 @@ private StaticTableSchema.Builder<RowData> addAttribute(
DataTypes.Field field,
RowData.FieldGetter fieldGetter) {
+ EnhancedType<Object> enhancedType =
getEnhancedType(field.getDataType());
return builder.addAttribute(
- getEnhancedType(field.getDataType()),
- a ->
- a.name(field.getName())
- .getter(
- rowData ->
-
DataStructureConverters.getConverter(
-
field.getDataType())
- .toExternalOrNull(
-
fieldGetter.getFieldOrNull(
-
rowData)))
- .setter(((rowData, t) -> {})));
+ enhancedType,
+ a -> {
+ a.name(field.getName())
+ .getter(
+ rowData ->
+
DataStructureConverters.getConverter(
+
field.getDataType())
+ .toExternalOrNull(
+
fieldGetter.getFieldOrNull(rowData)))
+ .setter(((rowData, t) -> {}));
+ buildRowAttributeConverter(field.getDataType())
+ .ifPresent(a::attributeConverter);
+ });
+ }
+
+ private java.util.Optional<AttributeConverter>
buildRowAttributeConverter(DataType dataType) {
+ if
(LogicalTypeRoot.ROW.equals(dataType.getLogicalType().getTypeRoot())) {
Review Comment:
Enums can be compared with the equality operator, so I'd rather use that
instead of `.equals`. Same in L117 and L159
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/RowDataToAttributeValueConverter.java:
##########
@@ -104,8 +156,36 @@ private <T> EnhancedType<T> getEnhancedType(DataType
dataType) {
EnhancedType.mapOf(
getEnhancedType(((KeyValueDataType)
dataType).getKeyDataType()),
getEnhancedType(((KeyValueDataType)
dataType).getValueDataType()));
+ } else if
(LogicalTypeRoot.ROW.equals(dataType.getLogicalType().getTypeRoot())) {
+ return (EnhancedType<T>) EnhancedType.of(Row.class);
} else {
return (EnhancedType<T>)
EnhancedType.of(dataType.getConversionClass());
}
}
+
+ private TableSchema<Row> buildRowTableSchema(DataType dataType) {
+ StaticTableSchema.Builder<Row> builder =
TableSchema.builder(Row.class);
+ AttributeConverterProvider newAttributeConverterProvider =
+ new ArrayAttributeConverterProvider();
+ builder.attributeConverterProviders(
+ newAttributeConverterProvider,
AttributeConverterProvider.defaultProvider());
+
+ DataTypes.Field[] fields = DataType.getFields(dataType).toArray(new
DataTypes.Field[0]);
Review Comment:
Any reason for the array conversion? `getFields` returns an `ArrayList`, so
calling `.get` on the list element has no downside, hence I do not see a reason
to make it an array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
