weiqingy commented on code in PR #657:
URL: https://github.com/apache/flink-agents/pull/657#discussion_r3300029797


##########
integrations/chat-models/openai/src/main/java/org/apache/flink/agents/integrations/chatmodels/openai/OpenAIResponsesModelConnection.java:
##########
@@ -74,6 +74,7 @@
  *   public static ResourceDesc openAIResponses() {
  *     return 
ResourceDescriptor.Builder.newBuilder(OpenAIResponsesModelConnection.class.getName())
  *             .addInitialArgument("api_key", System.getenv("OPENAI_API_KEY"))
+ *             .addInitialArgument("api_base_url", 
System.getenv("OPENAI_API_URL"))

Review Comment:
   This javadoc tweak isn't related to short-term-memory TTL. Mind splitting it 
out of this PR? Either it can ride as its own one-line hotfix, or it can be 
folded into the next OpenAI-touching change. Keeps the diff focused and the 
commit history honest — repo convention is one logical change per PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to