gaborgsomogyi commented on code in PR #27026:
URL: https://github.com/apache/flink/pull/27026#discussion_r3302721410
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/AbstractS3FileSystemFactory.java:
##########
@@ -245,4 +245,12 @@ protected FileSystem createFlinkFileSystem(
@Nullable
protected abstract S3AccessHelper
getS3AccessHelper(org.apache.hadoop.fs.FileSystem fs);
+
+ /**
+ * Updates the Hadoop configuration with delegation token credentials
provider. Subclasses can
+ * override this method to use a different credentials provider (e.g., SDK
v2 only).
+ */
+ protected void
updateDelegationTokenConfig(org.apache.hadoop.conf.Configuration hadoopConfig) {
+ AbstractS3DelegationTokenReceiver.updateHadoopConfig(hadoopConfig);
+ }
Review Comment:
What is the plan here?
Static methods can not be overridden, but they can hide parent static
methods.
In practice it means that the compiler will decide which method to execute
at the compile time, and not at the runtime, as it does with overridden
instance methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
