snuyanzin commented on code in PR #28256:
URL: https://github.com/apache/flink/pull/28256#discussion_r3302768386
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/join/BroadcastHashJoinTest.xml:
##########
@@ -174,46 +175,6 @@ Calc(select=[c, g])
+- Exchange(distribution=[broadcast])
+- Calc(select=[d, e, g])
+- TableSourceScan(table=[[default_catalog, default_database,
MyTable2]], fields=[d, e, f, g, h])
-]]>
- </Resource>
- </TestCase>
- <TestCase name="testInnerJoinWithJoinConditionPushDown">
- <Resource name="sql">
- <![CDATA[
-SELECT * FROM
- (select a, count(b) as b from MyTable1 group by a)
- join
- (select d, count(e) as e from MyTable2 group by d)
- on a = d and b = e and d = 2 and b = 1
-]]>
Review Comment:
here and for other joins (except for NestedLoop)
now Calcite is able to understand that `a == 2` and `e == 1`
after that it is able to push down these values to corresponding table
sources
as a result non nested loop join will fail as there is only `true` in join
condition.
when all joins are available then NestedLoop will be selected, there is also
e2e case in DecimalITCase in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
