Izeren commented on code in PR #27966:
URL: https://github.com/apache/flink/pull/27966#discussion_r3303671287
##########
flink-metrics/flink-metrics-otel/src/test/java/org/apache/flink/metrics/otel/OpenTelemetryEventReporterTest.java:
##########
@@ -166,4 +168,79 @@ public void testReportLogRecord() throws Exception {
});
});
}
+
+ @Test
+ public void testServiceNameAndVersionAppliedToResource() {
Review Comment:
I think that benefit from this test addition over e2e is marginal, but I
don't mind to have some fail fast test for this change too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
