snuyanzin commented on code in PR #28162:
URL: https://github.com/apache/flink/pull/28162#discussion_r3304154323
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/FilterPushDownSpec.java:
##########
@@ -110,11 +113,45 @@ public static SupportsFilterPushDown.Result apply(
}
}
+ /**
+ * Result of resolving {@link RexNode} predicates to {@link
ResolvedExpression}s. Carries a
+ * reverse lookup keyed on {@link ResolvedExpression} <em>instance
identity</em> so callers can
+ * walk the source's returned {@code accepted}/{@code remaining} lists and
recover the original
+ * input {@link RexNode}s.
+ *
+ * <p>Sources are required to return back the same instances they receive
(the apache pattern
+ * also used by {@link SupportsFilterPushDown}). A returned expression
that is not in this map
+ * indicates the source rebuilt the expression and is treated as an error
by the rule.
+ */
+ public static final class ResolvedPredicates {
+ /**
+ * Resolved expressions, in the same order as the input {@link
RexNode}s and 1:1 with them.
+ * Pass these to the source's filter / metadata filter push-down
method.
+ */
+ public final List<ResolvedExpression> resolvedExpressions;
Review Comment:
public class with public collection: everyone can change without an extra
method
is it intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
