gustavodemorais commented on code in PR #28235:
URL: https://github.com/apache/flink/pull/28235#discussion_r3304924981
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/inference/CallBindingCallContext.java:
##########
@@ -312,6 +312,11 @@ public int timeColumn() {
public Optional<ChangelogMode> changelogMode() {
return Optional.empty();
}
+
+ @Override
+ public int[] upsertKeyColumns() {
+ return new int[0];
Review Comment:
Can't we run into a out of index exception here? Can we guarantee that
int[0] is the shortest key?
What happens if the user has for example two primary keys defined for a
table and they're both of length 1? We randomly pick one? I first thought we
would expose all upsertKeys. If we only expose one, we have to make it clear in
the documentation and explain which one we expose to the user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
