snuyanzin commented on code in PR #28263:
URL: https://github.com/apache/flink/pull/28263#discussion_r3313845644
##########
flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroStreamingFileSinkITCase.java:
##########
@@ -58,13 +58,12 @@
* Simple integration test case for writing bulk encoded files with the {@link
StreamingFileSink}
* with Avro.
*/
-public class AvroStreamingFileSinkITCase extends AbstractTestBaseJUnit4 {
-
- @Rule public final Timeout timeoutPerTest = Timeout.seconds(20);
+@Timeout(value = 20)
+class AvroStreamingFileSinkITCase extends AbstractTestBase {
@Test
- public void testWriteAvroSpecific() throws Exception {
- File folder = TEMPORARY_FOLDER.newFolder();
+ void testWriteAvroSpecific() throws Exception {
+ File folder = TempDirUtils.newFolder(temporaryFolder.toPath());
Review Comment:
Why can't we use junit5's `@TempDir`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
