jubins commented on code in PR #28226:
URL: https://github.com/apache/flink/pull/28226#discussion_r3314546651
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/ApplicationExceptionsInfoWithHistory.java:
##########
@@ -91,10 +91,11 @@ public String toString() {
}
public static ApplicationExceptionsInfoWithHistory
fromApplicationExceptionHistory(
- Collection<ApplicationExceptionHistoryEntry> exceptions) {
+ Collection<ApplicationExceptionHistoryEntry> exceptions, int
maxSize) {
return new ApplicationExceptionsInfoWithHistory(
new ApplicationExceptionHistory(
exceptions.stream()
+ .limit(maxSize)
Review Comment:
good catch, that wasn't intentional. Pushed change which reverses the
history before `.limit(maxSize)` in
`ApplicationExceptionsInfoWithHistory#fromApplicationExceptionHistory`, so the
endpoint now returns the newest `N` entrier
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/ApplicationExceptionsInfoWithHistory.java:
##########
@@ -91,10 +91,11 @@ public String toString() {
}
public static ApplicationExceptionsInfoWithHistory
fromApplicationExceptionHistory(
- Collection<ApplicationExceptionHistoryEntry> exceptions) {
+ Collection<ApplicationExceptionHistoryEntry> exceptions, int
maxSize) {
return new ApplicationExceptionsInfoWithHistory(
new ApplicationExceptionHistory(
exceptions.stream()
+ .limit(maxSize)
Review Comment:
good catch, that wasn't intentional. Pushed change which reverses the
history before `.limit(maxSize)` in
`ApplicationExceptionsInfoWithHistory#fromApplicationExceptionHistory`, so the
endpoint now returns the newest `N` entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
