weiqingy commented on code in PR #709: URL: https://github.com/apache/flink-agents/pull/709#discussion_r3315347860
########## python/flink_agents/api/tests/test_cross_language_event_snapshots.py: ########## @@ -0,0 +1,455 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# +"""Cross-language event SerDe snapshot tests.""" + +import json +import os +from pathlib import Path +from typing import ClassVar +from uuid import UUID + +import pytest + +from flink_agents.api.chat_message import ChatMessage, MessageRole +from flink_agents.api.events.chat_event import ChatRequestEvent, ChatResponseEvent +from flink_agents.api.events.context_retrieval_event import ( + ContextRetrievalRequestEvent, + ContextRetrievalResponseEvent, +) +from flink_agents.api.events.event import Event, InputEvent, OutputEvent +from flink_agents.api.events.tool_event import ToolRequestEvent, ToolResponseEvent +from flink_agents.api.vector_stores.vector_store import Document + +_REPO_ROOT = Path(__file__).resolve().parents[4] +_SNAPSHOT_DIR = _REPO_ROOT / "e2e-test" / "cross-language-event-snapshots" + +_FIXED_EVENT_ID = UUID("00000000-0000-0000-0000-000000000001") +_FIXED_REQUEST_ID = UUID("00000000-0000-0000-0000-000000000002") +_FIXED_TOOL_CALL_ID = "call_aaaa" + + +def _regenerate_enabled() -> bool: + return os.environ.get("REGENERATE_SNAPSHOTS", "").lower() in {"1", "true", "yes"} + + +def _force_id(event: Event, fixed_id: UUID) -> Event: + object.__setattr__(event, "id", fixed_id) + return event + + +def _write_python_snapshot(name: str, event: Event) -> None: + target = _SNAPSHOT_DIR / "python" / name + target.parent.mkdir(parents=True, exist_ok=True) + target.write_text(event.model_dump_json(indent=2) + "\n") + + +def _assert_python_snapshot_stable(name: str, event: Event) -> None: + actual = json.loads(event.model_dump_json()) + committed_path = _SNAPSHOT_DIR / "python" / name + if not committed_path.exists(): Review Comment: Mirror of the same concern on the Java side: `pytest.skip` when the committed snapshot is missing turns a real wire-format regression into a silent pass-as-skipped. The `REGENERATE_SNAPSHOTS=1` skips on the regenerate tests are legitimate (the env var is the gate). For the stability / round-trip helpers at lines 64 and 76, was the symmetric `pytest.skip` intentional — any case where a missing snapshot should soft-pass? If not, would `pytest.fail(...)` or a plain `assert committed_path.exists()` be a tighter fit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
