snuyanzin commented on code in PR #28162:
URL: https://github.com/apache/flink/pull/28162#discussion_r3320109906
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/FilterPushDownSpec.java:
##########
@@ -111,10 +111,11 @@ public static SupportsFilterPushDown.Result apply(
}
/**
- * Converts {@link RexNode} predicates to {@link ResolvedExpression}s
using the given row type.
- * Shared between physical and metadata filter push-down paths.
+ * Converts {@link RexNode} predicates to {@link ResolvedExpression}s,
preserving 1:1 input
+ * order so callers can correlate by position. Shared between physical and
metadata filter
+ * push-down paths.
*/
- static List<ResolvedExpression> resolvePredicates(
+ public static List<ResolvedExpression> resolvePredicates(
Review Comment:
didn't get why it is public if it is used in same package only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
