nattilabalint opened a new pull request, #28275:
URL: https://github.com/apache/flink/pull/28275
## What is the purpose of the change
Fix the proxy connection pool poisoning (putting back closed connections to
the pool) on 304 Not Modified responses.
This is happening, because Flink severe the connections from its end when
respond with HTTP_304, without explicitly setting the Connection: close header
on the response.
## Brief change log
The Connection: close header added to the response.
## Verifying this change
This change added tests and can be verified as follows:
- Added unit test to verify the Connection: close header
- The proxy connection pool poisoning related errors disappeared (repro
env: Flink dashboard behind Knox, browser reload sends 'If-Modified-Since'
header for cached static assets (.js, .css), Flink respond with HTTP_304, no
failed subsequent GET failures anymore)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Gemini 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
