rosemarYuan commented on code in PR #713:
URL: https://github.com/apache/flink-agents/pull/713#discussion_r3328277042
##########
python/flink_agents/e2e_tests/e2e_tests_resource_cross_language/yaml_cross_language_test.py:
##########
@@ -154,8 +154,10 @@ def test_yaml_cross_language_agent(
# Math path went through the Java ``calculateBMI`` tool:
# 70 / (1.75 * 1.75) ≈ 22.86, so the final answer should mention 22.
- assert "22" in actual_result[0], f"math answer missing '22':
{actual_result[0]!r}"
# Creative path doesn't use any tool.
- assert "cat" in actual_result[1].lower(), (
- f"creative answer missing 'cat': {actual_result[1]!r}"
- )
+ # NOTE: We join all results and search without relying on order, because
Review Comment:
Good catch! Fixed in the same way — joined all results and made the
assertion order-insensitive in chat_model_cross_language_test.py as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
