weiqingy opened a new issue, #715: URL: https://github.com/apache/flink-agents/issues/715
### Search before asking - [x] I searched in the [issues](https://github.com/apache/flink-agents/issues) and found nothing similar. ### Description #698 renamed the setup-layer `BaseChatModelSetup.chat()` parameters to `promptArgs` (prompt-template variables) and `modelParams` (model parameters), to remove the confusion between two near-synonymous names ([reviewer feedback](https://github.com/apache/flink-agents/pull/698#discussion_r3322887198)). One overloaded use was deliberately scoped out of that PR: the connection layer still names its model-parameters argument `arguments`: ```java // BaseChatModelConnection.java public abstract ChatMessage chat( List<ChatMessage> messages, List<Tool> tools, Map<String, Object> arguments); ``` So the setup's `modelParams` is passed straight into the connection's `arguments` — the same concept under two names across a single call hop — and `arguments` here also collides with the (now-renamed) prompt-template `arguments`. **Proposed:** rename the connection-layer `arguments` → `modelParams` (Java) so the name is consistent end-to-end. **Scope (Java):** - `BaseChatModelConnection.chat(...)` (interface + Javadoc) - `PythonChatModelConnection` (Pemja bridge) - Provider connections: Anthropic, Ollama, Bedrock, OpenAI (Responses + Completions + AzureOpenAI), AzureAI - Affected tests **Out of scope:** - Python connection layer — already uses `**kwargs` for model params, so it is already consistent. - MCP `arguments` (`MCPTool` / `MCPPrompt` / `MCPServer`) — an unrelated concept (MCP tool-call parameters). **Compatibility:** this changes a parameter name on a public abstract method, so custom `BaseChatModelConnection` implementations would update their override signature. It is erasure-compatible (positional), so call sites are unaffected. This is a low-urgency naming-consistency cleanup. ### Are you willing to submit a PR? - [x] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
