da-daken commented on PR #657: URL: https://github.com/apache/flink-agents/pull/657#issuecomment-4582593252
> Thanks @da-daken for working on this, and thanks @weiqingy for the review. > > I also left a few comments. In addition to the inline comments, I'd suggest to re-organize the PR commits. > > * We do not allow merge commits in PRs. Please use rebase for conflict resolving. > * Please separate unrelated hotfixes from the major changes. > * You may check the [community guidelines](https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/#3-separate-refactoring-cleanup-and-independent-changes) for instructions and examples. hi @xintongsong , I have rebased the branch, adopted your review suggestions, and removed the changes in OpenAIResponsesModelConnection because 'api_base_url' is optional, so I will not submit the hotfix. PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
