Dennis-Mircea commented on code in PR #1118:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1118#discussion_r3330845311
##########
docs/content/docs/operations/helm.md:
##########
@@ -53,23 +54,27 @@ namespace to the [watched
namespaces](#watching-only-specific-namespaces).
Helm provides different ways to override the default installation parameters
(contained in `values.yaml`) for the Helm chart.
To override single parameters you can use `--set`, for example:
+
```
helm install --set image.repository=apache/flink-kubernetes-operator --set
image.tag={{< stable >}}{{< version >}}{{< /stable >}}{{< unstable >}}latest{{<
/unstable >}} flink-kubernetes-operator helm/flink-kubernetes-operator
```
+
Note, you should escape special characters in your `--set` lines, for example:
+
```
helm install --set
defaultConfiguration."log4j-operator\.properties"=rootLogger.level\=DEBUG
flink-kubernetes-operator helm/flink-kubernetes-operator
```
You can also provide your custom values file by using the `-f` flag:
+
```
helm install -f myvalues.yaml flink-kubernetes-operator
helm/flink-kubernetes-operator
```
The configurable parameters of the Helm chart and which default values as
detailed in the following table:
| Parameters | Description
| Default Value
|
-|------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| ---------------------------------------------- |
--------------------------------------------------------------------------------------------------------------------------------------------------------------
|
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
Review Comment:
Revert this unnecessary change...
##########
docs/content.zh/docs/operations/helm.md:
##########
@@ -128,6 +128,8 @@ The configurable parameters of the Helm chart and which
default values as detail
| watchNamespaces | List of kubernetes
namespaces to watch for FlinkDeployment changes, empty means all namespaces.
|
|
| webhook.create | Whether to enable
validating and mutating webhooks for flink-kubernetes-operator.
| true
|
| webhook.keystore | The ConfigMap of webhook
key store.
| useDefaultPassword:
true
|
+| webhook.keystore.pkcs12Profile | PKCS12 encryption profile
for the webhook certificate. Options: `Modern2023`, `LegacyDES`, `LegacyRC2`.
Use `Modern2023` for FIPS-compliant environments. |
+
Review Comment:
Remove the empty line here. With this in place the current table is broken.
##########
docs/content.zh/docs/operations/helm.md:
##########
@@ -128,6 +128,8 @@ The configurable parameters of the Helm chart and which
default values as detail
| watchNamespaces | List of kubernetes
namespaces to watch for FlinkDeployment changes, empty means all namespaces.
|
|
| webhook.create | Whether to enable
validating and mutating webhooks for flink-kubernetes-operator.
| true
|
| webhook.keystore | The ConfigMap of webhook
key store.
| useDefaultPassword:
true
|
+| webhook.keystore.pkcs12Profile | PKCS12 encryption profile
for the webhook certificate. Options: `Modern2023`, `LegacyDES`, `LegacyRC2`.
Use `Modern2023` for FIPS-compliant environments. |
Review Comment:
This line should have an extra `|`. You just need to copy paste the same
line from English documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
