xintongsong commented on PR #721: URL: https://github.com/apache/flink-agents/pull/721#issuecomment-4590025407
Hi @weiqingy , It seems to me there are some misunderstanding of the TTL clean-up strategies. I checked the implementation of [StateTtlConfig](https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java) and find that: 1. The cleanup strategies are additive rather than exclusive. This means a config option that only allows one value may not be expressive enough. 2. `INCREMENTAL` and `ROCKSDB_COMPACTION_FILTER` is enabled by default. The only strategy what won't be enabled by default is `FULL_SNAPSHOT`. Based on these observations, I'm leaning towards not to introduce this new option. Because the whole cleanup strategy mechanism is too complex for the users to understand and tune, and the default behaviors should be good enough for most of the use cases. Unless we see a concrete need for this fine-tuning, these knobs might be unnecessary. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
