soin08 commented on code in PR #28142: URL: https://github.com/apache/flink/pull/28142#discussion_r3336028692
########## flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/filter/BoundComparison.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.state.api.filter; + +import javax.annotation.Nullable; + +import java.io.Serializable; + +/** Comparison strategy resolved from the bound types at filter construction time. */ +enum BoundComparison implements Serializable { + LONG { + @Override + public int compare(Object a, Object b) { + return Long.compare(((Number) a).longValue(), ((Number) b).longValue()); + } + }, + DOUBLE { + @Override + public int compare(Object a, Object b) { + return Double.compare(((Number) a).doubleValue(), ((Number) b).doubleValue()); + } + }, + NATURAL { + @SuppressWarnings("unchecked") + @Override + public int compare(Object a, Object b) { + return ((Comparable<Object>) a).compareTo(b); + } + }; + + public abstract int compare(Object a, Object b); + + static BoundComparison resolve(@Nullable Object lower, @Nullable Object upper) { + if (isFloatingPoint(lower) || isFloatingPoint(upper)) { + return DOUBLE; + } + if (lower instanceof Number || upper instanceof Number) { + return LONG; + } + return NATURAL; + } Review Comment: > SavepointFilters.extractValue() calls literal.getValueAs(cls) where cls is derived from the column's own DataType.getConversionClass(). This means the bound is already normalised to the exact Java type of the column The bound is not automatically normalized to the type of the column. If a query `SELECT k FROM int_state_table WHERE k >= 3 AND k <= 7` is executed, `SavepointFilters.extractValue()` will be called on `ValueLiteralExpression(3)` and `ValueLiteralExpression(7)`, and `literal.getOutputDataType().getConversionClass();` will return `java.lang.Integer` for them. If `k` is not `INT`, the comparison will fail. Without `BoundComparison`, users would have to write explicit casts in their `WHERE` clauses. You're right about the correctness though, I will work on retiring BoundComparison and providing `Comparator<Object>` to `RangeKeyFilter` based on `DataType`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
