snuyanzin commented on code in PR #28170:
URL: https://github.com/apache/flink/pull/28170#discussion_r3339162159


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala:
##########
@@ -208,7 +208,7 @@ class FlinkTypeFactory(
         getTypeSystem,
         originalType.asInstanceOf[BasicSqlType],
         isNullable,

Review Comment:
   yeah, should be fine now
   however anyway next week or the week after next week I'm going to discuss it 
first in Flink ML since it brings some user facing changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to