Efrat19 commented on code in PR #28257: URL: https://github.com/apache/flink/pull/28257#discussion_r3340506260
########## flink-runtime/src/main/java/org/apache/flink/runtime/state/metrics/StateMetricBase.java: ########## Review Comment: That's also a valid solution, except we'll need to change it in all ~30 calls to `loopUpdateCounter` across `StateMetricBase` descendants, Also I liked in the current implementation that the 1st entry is always sampled while with `return clearCount == 0;` for `sampleInterval = 100` no metric is exported until you access the state 100 times -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
