joeyutong commented on issue #724: URL: https://github.com/apache/flink-agents/issues/724#issuecomment-4601962987
@weiqingy Thanks for confirming. I have not started working on the upstream fix yet, so please feel free to put up the `release-0.2` backport PR. The Java-side fix sounds good to me. Making `AgentPlan#getResource` synchronized looks like the minimal fix for `release-0.2`, and the regression test from the repro should cover it. One related question: should we also cover the Python resource path in this backport? `release-0.2` has a similar unsynchronized cache in Python `AgentPlan.get_resource()`. On main this seems to be avoided by the newer resource lifecycle: resources are opened through `ResourceCache`, and chat model setup resolves its sub-resources during `open()` instead of lazily inside `chat()`. Do you think the `release-0.2` PR should include a minimal Python-side guard as well, or keep the scope to Java only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
