raminqaf commented on code in PR #28277:
URL: https://github.com/apache/flink/pull/28277#discussion_r3354310991
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/materializedtable/SqlAlterMaterializedTableAsQueryConverter.java:
##########
@@ -54,13 +55,12 @@ protected Function<ResolvedCatalogMaterializedTable,
List<TableChange>> gatherTa
SqlAlterMaterializedTableAsQuery sqlAlterTableAsQuery,
ConvertContext context) {
return oldTable -> {
// Validate and extract schema from query
- String originalQuery =
context.toQuotedSqlString(sqlAlterTableAsQuery.getAsQuery());
- SqlNode validatedQuery =
-
context.getSqlValidator().validate(sqlAlterTableAsQuery.getAsQuery());
- String definitionQuery = context.toQuotedSqlString(validatedQuery);
+ SqlNode asQuery = sqlAlterTableAsQuery.getAsQuery();
+ SqlNode validatedQuery =
context.getSqlValidator().validate(asQuery);
+ String expandedQuery = context.toQuotedSqlString(validatedQuery);
PlannerQueryOperation queryOperation =
new PlannerQueryOperation(
- context.toRelRoot(validatedQuery).project(), () ->
definitionQuery);
+ context.toRelRoot(validatedQuery).project(), () ->
expandedQuery);
Review Comment:
Changes are minimal:
- extracted asQuery as variable
- renamed `definitionQuery` to `expandedQuery`
- Moved the extraction of the `originalQuery` closer to its caller
Should I revert and keep it even smaller?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/materializedtable/SqlAlterMaterializedTableAsQueryConverter.java:
##########
@@ -54,13 +55,12 @@ protected Function<ResolvedCatalogMaterializedTable,
List<TableChange>> gatherTa
SqlAlterMaterializedTableAsQuery sqlAlterTableAsQuery,
ConvertContext context) {
return oldTable -> {
// Validate and extract schema from query
- String originalQuery =
context.toQuotedSqlString(sqlAlterTableAsQuery.getAsQuery());
- SqlNode validatedQuery =
-
context.getSqlValidator().validate(sqlAlterTableAsQuery.getAsQuery());
- String definitionQuery = context.toQuotedSqlString(validatedQuery);
+ SqlNode asQuery = sqlAlterTableAsQuery.getAsQuery();
+ SqlNode validatedQuery =
context.getSqlValidator().validate(asQuery);
+ String expandedQuery = context.toQuotedSqlString(validatedQuery);
PlannerQueryOperation queryOperation =
new PlannerQueryOperation(
- context.toRelRoot(validatedQuery).project(), () ->
definitionQuery);
+ context.toRelRoot(validatedQuery).project(), () ->
expandedQuery);
Review Comment:
Changes are minimal:
- extracted `asQuery` as variable
- renamed `definitionQuery` to `expandedQuery`
- Moved the extraction of the `originalQuery` closer to its caller
Should I revert and keep it even smaller?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
