davidradl commented on PR #28106: URL: https://github.com/apache/flink/pull/28106#issuecomment-4620813743
@Dennis-Mircea My AI was happy with the changes - and made some minor suggestions, I, thought I would share and see if you wanted to address them. Consider extracting polling utility - The waitUntilConditionWithTimeout pattern could be a reusable test utility Document timeout values - 10s and 30s timeouts are reasonable but could have brief comments explaining why Thread state handling - The !t.isAlive() check is good defensive programming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
