Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r97696231
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.addons.hbase;
+
+import org.apache.flink.api.common.typeinfo.BasicArrayTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.util.Preconditions;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.Pair;
+
+import java.io.Serializable;
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.util.List;
+import java.util.Map;
+import java.util.HashMap;
+import java.util.ArrayList;
+import java.util.Date;
+
+/**
+ * Helps to specify an HBase Table's schema
+ */
+public class HBaseTableSchema implements Serializable {
+
+ // A Map with key as column family.
+ private final Map<String, List<Pair>> familyMap =
+ new HashMap<String, List<Pair>>();
+
+ // Allowed types. This may change.
+ // TODO : Check if the Date type should be the one in java.util or the
one in java.sql
+ private static Class[] CLASS_TYPES = {
+ Integer.class, Short.class, Float.class, Long.class,
String.class, Byte.class, Boolean.class, Double.class, BigInteger.class,
BigDecimal.class, Date.class
+ };
+ private static byte[] EMPTY_BYTE_ARRAY = new byte[0];
+ public void addColumns(String family, String qualifier,
TypeInformation<?> type) {
--- End diff --
addColumns -> addColumn ?
I'm not sure whether we should use `TypeInformation` or `Class` here.
Because TypeInformation indicates that we use Flink Serialization framework to
serialize primitives. But it doesn't happen here. Maybe `Class` is a simpler
and better choice ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
