snuyanzin commented on code in PR #28336:
URL: https://github.com/apache/flink/pull/28336#discussion_r3369132520


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/StringFunctionsITCase.java:
##########


Review Comment:
   we ca do it if it is not very time consuming
   however I would recommend to split it may be in 2 commits
   1. current change
   2. test migration
   
   and be sure that ci is green before second step and after



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to