wzhero1 opened a new pull request, #790:
URL: https://github.com/apache/flink-agents/pull/790

   Linked issue: #772
   
   ### Purpose of change
   
   The general-text paragraph after the `from_table`/`to_table` tabs in
   `docs/content/docs/development/integrate_with_flink.md` sits outside the
   `{{< /tabs >}}` block, so readers apply it to both languages. It claimed
   `to_table()` requires both `Schema` and `TypeInformation`, which is true for
   Python only — the Java API accepts only `Schema`:
   
   - Java: `Table toTable(Schema schema)` 
(`api/src/main/java/org/apache/flink/agents/api/AgentBuilder.java:90`)
   - Python: `def to_table(self, schema, output_type)` 
(`python/flink_agents/api/execution_environment.py:78`)
   - e2e tests call single-arg `.toTable(outputSchema)` in 
`FlinkIntegrationTest`, `ReActAgentTest`, `SkillsIntegrationTest`.
   
   This change scopes the "Schema + TypeInformation" requirement to Python, 
adds an
   explicit note that Java's `toTable(Schema)` does not need `TypeInformation`, 
and
   narrows the info hint to Python.
   
   ### Tests
   
   Docs-only change. Verified locally by building the site with Hugo (`hugo` in
   `docs/`); the page renders the per-language list and the info hint correctly.
   
   ### API
   
   No. Documentation-only; no public API changed.
   
   ### Documentation
   
   - [x] `doc-included`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to