Ryan-Nightwish opened a new issue, #803:
URL: https://github.com/apache/flink-agents/issues/803

   ### Search before asking
   
   - [x] I searched in the 
[issues](https://github.com/apache/flink-agents/issues) and found nothing 
similar.
   
   ### Description
   
   Found during workflow agent quickstart doc verification.
   
   Collection of issues for
   `docs/content/docs/get-started/quickstart/workflow_agent.md` and the
   associated example code:
   
   1. **Python `process_input` code snippet differs from source** (doc line 
131-136 vs `review_analysis_agent.py` line 91) — the doc shows:
      ```python
      input_event = InputEvent.from_event(event)
      input: ProductReview = input_event.input
      ```
      but the actual source uses:
      ```python
      input = ProductReview.model_validate(InputEvent.from_event(event).input)
      ```
      The doc version omits the `model_validate()` call, which is semantically 
different.
   
   2. **Python env-setup comment wrongly mentions `ProductSuggestionAgent`** 
(doc line 51-52) — the "Prepare Agents Execution Environment" snippet's comment 
says the connection is "used by the ReviewAnalysisAgent **and 
ProductSuggestionAgent**", but the section is introducing the general 
environment setup and the actual single-agent source comment only mentions 
`ReviewAnalysisAgent`.
   
   3. **Python examples fail at runtime — `resources/` directory contains 
non-JSON files** (product bug) —`workflow_single_agent_example.py` uses 
`FileSource` to read the entire `resources/` directory. However, 
`resources/skills/math-calculator/SKILL.md` (bundled for the Skills Agent 
quickstart) also lives there. `FileSource` recurses into the subdirectory and 
tries to parse `SKILL.md` as JSON, producing:
      ```
      ValidationError: 1 validation error for ProductReview
        Invalid JSON: invalid number at line 1 column 2
        [type=json_invalid, input_value='---', input_type=str]
      ```
      This issue seems to be solved by: [#782 
](https://github.com/apache/flink-agents/pull/782)
   
   ### How to reproduce
   
   - 
   
   ### Version and environment
   
   Flink Agents 0.3.0 (`main`).
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to