HundalTaran commented on PR #28266:
URL: https://github.com/apache/flink/pull/28266#issuecomment-4647227208
> Thanks for the review @davidradl! I've updated the Javadoc to address all
your points:
>
> 1. **Materialized tables** – clarified that the method supports both
regular catalog tables and materialized tables (the
implementation in `ContextResolvedTable.copy()` already handles this
case). Only views are rejected.
>
> 2. **Invalid options** – added a paragraph explaining that option
validation is lazy (happens at planning/execution
time, not at `from()` call time), consistent with how SQL OPTIONS hints
work.
>
> 3. **Why `Map<String, String>`** – added an explanation that this is
consistent with the entire Table/SQL ecosystem
(`CatalogTable.getOptions()`, DDL WITH clauses, SQL OPTIONS hints all use
string key-value pairs). Typed values are parsed
by the connector factory.
>
> 4. **Documentation** – added a section to the Table API docs
(`common.md`) with examples showing why and how to use this
feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
