Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3035
  
    Quick question: I am not sure if this scenario can happen like that:
    
    > But in this approach an unlikely bug will be still occurred:
    zkHandler.prepareAndCommitOffsets(offsets); throws important exception when 
running is true
    then running becomes false and we get a swallowed exception in this rare 
case.
    Maybe at least, should log the exception anyway?
    
    When the exception is thrown in 
`zkHandler.prepareAndCommitOffsets(offsets)` and `running = true` then the 
exception does not get swallowed. The `running` flag can become false only 
after the exception was thrown. If the flag becomes false due to another 
reason, then there is either another root cause for the failure, or the 
operator is shutting down anyways. In both cases, it is probably okay to not 
report the exception.
    
    Please let me know if you think I have overlooked something here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to