AlexYinHan commented on code in PR #28295:
URL: https://github.com/apache/flink/pull/28295#discussion_r3380261189
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##########
@@ -147,24 +150,24 @@ public static SavepointRestoreSettings none() {
}
public static SavepointRestoreSettings forPath(String savepointPath) {
- return forPath(
- savepointPath,
-
StateRecoveryOptions.SAVEPOINT_IGNORE_UNCLAIMED_STATE.defaultValue());
+ return forPath(savepointPath, null);
}
public static SavepointRestoreSettings forPath(
- String savepointPath, boolean allowNonRestoredState) {
- checkNotNull(savepointPath, "Savepoint restore path.");
- return new SavepointRestoreSettings(
- savepointPath,
- allowNonRestoredState,
- StateRecoveryOptions.RESTORE_MODE.defaultValue());
+ String savepointPath, @Nullable Boolean allowNonRestoredState) {
+ return new SavepointRestoreSettings(savepointPath,
allowNonRestoredState, null);
Review Comment:
Sure. All ```forPath``` methods now either call ```checkNotNull``` or add
```@Nullable``` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
