autophagy commented on code in PR #28326:
URL: https://github.com/apache/flink/pull/28326#discussion_r3381549067


##########
flink-table/flink-table-test-utils/src/main/java/org/apache/flink/table/runtime/functions/ProcessTableFunctionTestHarness.java:
##########
@@ -543,6 +968,9 @@ public static class Builder<OUT> {
         private final Map<String, TableArgumentConfiguration> tableArgs = new 
HashMap<>();
         private final Map<String, PartitionConfiguration> partitionConfigs = 
new HashMap<>();
         private final Map<String, StateArgumentConfiguration> stateArgs = new 
HashMap<>();
+        @Nullable private String onTimeColumnName = null;
+        private final Map<String, Long> initialWatermarks = new HashMap<>();
+        @Nullable private Long initialWatermarkForAll = null;

Review Comment:
   Yeah, I agree - the initial watermark stuff isn't really useful as a builder 
option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to