rosemarYuan commented on code in PR #821: URL: https://github.com/apache/flink-agents/pull/821#discussion_r3386797491
########## .github/workflows/cel-conformance.yml: ########## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: CEL Cross-Language Conformance + +on: + push: + branches: [ main, 'release-*' ] + paths: + - 'runtime/src/main/java/org/apache/flink/agents/runtime/condition/**' + - 'runtime/src/test/java/org/apache/flink/agents/runtime/condition/**' + - 'e2e-test/cel-fixtures/**' + - 'plan/src/main/java/org/apache/flink/agents/plan/condition/**' + - 'python/flink_agents/runtime/condition/**' + - 'python/flink_agents/plan/condition/**' + - 'python/flink_agents/runtime/tests/test_local_runner_condition.py' + - 'python/flink_agents/runtime/tests/test_local_runner_mixed_or_dedup.py' + - '.github/workflows/cel-conformance.yml' + pull_request: + branches: [ main, 'release-*' ] + paths: + - 'runtime/src/main/java/org/apache/flink/agents/runtime/condition/**' + - 'runtime/src/test/java/org/apache/flink/agents/runtime/condition/**' + - 'e2e-test/cel-fixtures/**' + - 'plan/src/main/java/org/apache/flink/agents/plan/condition/**' + - 'python/flink_agents/runtime/condition/**' + - 'python/flink_agents/plan/condition/**' + - 'python/flink_agents/runtime/tests/test_local_runner_condition.py' + - 'python/flink_agents/runtime/tests/test_local_runner_mixed_or_dedup.py' + - '.github/workflows/cel-conformance.yml' + workflow_dispatch: + +jobs: + conformance: + name: cel-conformance + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + + # Fixtures live in e2e-test/cel-fixtures/ (single source of truth). + # Java reads them via pom.xml <testResource>; Python via symlink. + # No diff step needed — both sides reference the same physical files. + + # Cross-language check: CEL reserved keyword sets must be identical. + # Skipped automatically if the Python side hasn't landed yet (PR2 alone). + - name: Ensure CEL reserved keywords are identical across languages + run: | + set -euo pipefail + if [ ! -f python/flink_agents/plan/condition/cel_reserved.py ]; then + echo "Python cel_reserved.py not present yet; skipping cross-language check." + exit 0 + fi + python3 << 'PY' + import re, sys + + java_file = 'plan/src/main/java/org/apache/flink/agents/plan/condition/CelReserved.java' Review Comment: Thanks for flagging this — I hadn't realized the deps shaded into the uber-jar needed LICENSE entries. You're right that this PR is where dev.cel enters the uber-jar, so this is the right place to handle it. Pushed a commit adding a bundled-dependency section to LICENSE listing the four transitives (`dev.cel`, antlr4-runtime, re2j, protobuf-java; Apache 2.0 / BSD-3-Clause) and appending the upstream copyright lines to NOTICE. On `cel-conformance.yml `— my miss, I forgot to update the workflow after the refactor, and the issues you called out all hold. I fixed them locally first, then moved the fix commit over to the Python implementation PR. Rationale: the cross-language parity check only becomes meaningful once `cel_reserved.py` lands, so landing the fix together with the Python side makes for a cleaner story and lets us verify both ends in one go. The Python PR will go out after this Java PR is reviewed — looking forward to your eyes on that one too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
