Au-Miner commented on PR #28150: URL: https://github.com/apache/flink/pull/28150#issuecomment-4678293335
> Thanks for picking this up - I'm reporter of [FLINK-39589](https://issues.apache.org/jira/browse/FLINK-39589) here. > > One nit: the ternary `requiresCopy ? windowKey : windowKeySerializer.copy(windowKey)` reads as backwards at first glance (copying only when `requiresCopy` is false). Could we add a comment to explain? > > ``` > // When requiresCopy=true the iterator already returned a fresh copy. > // Otherwise it reuses a mutable WindowKey, so we must copy here before > // it escapes into the timer queue via combine(). > ``` Thanks for the reply. The notes have been added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
