wenjin272 commented on PR #830: URL: https://github.com/apache/flink-agents/pull/830#issuecomment-4679832184
Thanks for the PR. On the implementation details, the comments from @weiqingy and @GreatEugenius already cover my feedback. One point I'd like to emphasize, which both reviewers also raised: the code examples in the docs rely on many helper functions and global variables that aren't shown, which makes the examples hard for users to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
