reswqa commented on code in PR #28402:
URL: https://github.com/apache/flink/pull/28402#discussion_r3401497003
##########
flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java:
##########
@@ -247,5 +247,64 @@ public class HistoryServerOptions {
text(CONFIGURE_CONSISTENT))
.build());
+ public static final ConfigOption<HistoryServerArchiveStorageType>
+ HISTORY_SERVER_ARCHIVE_STORAGE_TYPE =
+ key("historyserver.archive.storage.type")
+ .enumType(HistoryServerArchiveStorageType.class)
+ .defaultValue(HistoryServerArchiveStorageType.FILE)
+ .withDescription(
+ Description.builder()
+ .text("The type of archive
storage.")
+ .build());
+
+ public static final ConfigOption<String>
HISTORY_SERVER_ARCHIVE_ROCKSDB_NATIVE_LIB_DIR =
+ key("historyserver.archive.rocksdb.native-lib-dir")
+ .stringType()
+ .defaultValue(System.getProperty("java.io.tmpdir"))
+ .withDescription(
+ "Base directory used to extract the RocksDB native
library for the "
+ + "HistoryServer archive storage. Each
HistoryServer instance "
+ + "extracts the library into a unique
sub-directory under this "
+ + "directory. Defaults to the JVM
'java.io.tmpdir' when not "
+ + "configured. Only applies when "
+ + "'historyserver.archive.storage.type' is
'ROCKSDB'.");
+
+ /** Compression type used for the non-bottommost levels of the RocksDB SST
files. */
+ public static final ConfigOption<String>
HISTORY_SERVER_ARCHIVE_ROCKSDB_COMPRESSION =
+ key("historyserver.archive.rocksdb.compression")
+ .stringType()
+ .defaultValue("LZ4_COMPRESSION")
+ .withDescription(
+ "Compression type used for the non-bottommost
levels of the RocksDB "
+ + "SST files. Allowed values are the names
of the RocksDB "
+ + "'CompressionType' enum (e.g.
'NO_COMPRESSION', "
+ + "'SNAPPY_COMPRESSION',
'LZ4_COMPRESSION', "
+ + "'ZSTD_COMPRESSION'). Only applies when "
+ + "'historyserver.archive.storage.type' is
'ROCKSDB'.");
+
+ /** Compression type used for the bottommost level of the RocksDB SST
files. */
+ public static final ConfigOption<String>
HISTORY_SERVER_ARCHIVE_ROCKSDB_BOTTOMMOST_COMPRESSION =
+ key("historyserver.archive.rocksdb.bottommost-compression")
Review Comment:
Could we use enum type rather than String here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
