snuyanzin commented on code in PR #28381:
URL: https://github.com/apache/flink/pull/28381#discussion_r3409370466
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##########
@@ -170,6 +170,19 @@ private TableConfigOptions() {}
+ "For example, it prevented using rows in
computed columns or join keys. "
+ "The new behavior takes the nullability
into consideration.");
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Boolean> TABLE_GROUP_BY_ORDINAL_ENABLED =
+ key("table.group-by-ordinal-enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Enables positional references in the 'GROUP BY'
clause, where an"
+ + " integer literal n refers to the n-th
expression in the"
+ + " SELECT list. WARNING: this changes the
meaning of existing"
+ + " queries (today 'GROUP BY 1' groups by
the constant 1)."
+ + " Disabled by default; intended to flip
to true in a future"
Review Comment:
isn't it a user facing behavior which should be discussed first in ML?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
