raminqaf commented on code in PR #28332:
URL: https://github.com/apache/flink/pull/28332#discussion_r3413237862
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/experimental/SocketStreamIteratorTest.java:
##########
@@ -104,4 +104,45 @@ public void run() {
.isInstanceOf(RuntimeException.class)
.hasMessageContaining("test");
}
+
+ @Test
+ void testNotifyOfErrorBeforeConnection() throws Exception {
+ // Test that notifyOfError() can be called before connectedSocket is
initialized
+ // (i.e., before any data has been read)
Review Comment:
Do we need this comments? Seems a bit duplicated. The name of the test
already covers it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
