raminqaf commented on code in PR #28403:
URL: https://github.com/apache/flink/pull/28403#discussion_r3413270488


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkChangelogModeInferenceProgram.scala:
##########
@@ -1604,6 +1619,21 @@ class FlinkChangelogModeInferenceProgram extends 
FlinkOptimizeProgram[StreamOpti
     modifyKindSetTrait.modifyKindSet
   }
 
+  /** Whether the node or any node in its input subtree produces UPDATE 
changes. */
+  private def containsUpdates(rel: RelNode): Boolean =
+    getModifyKindSet(rel).contains(ModifyKind.UPDATE) ||
+      rel.getInputs.exists(input => containsUpdates(input))
+
+  /** Renders a node's type and changelog mode, for example 
"Sink(changelogMode=[NONE])". */

Review Comment:
   Now the sink contains the changelogMode
   
   ```
   Sink(ChangelogMode=[I,UB,UA,D])
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to