davidradl commented on code in PR #28385:
URL: https://github.com/apache/flink/pull/28385#discussion_r3420052618
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##########
@@ -658,6 +659,29 @@ void testCreateTableValidDistribution() {
Collections.singletonList("a"), null)))));
}
+ @Test
+ void testCreateTableWithConnection() {
+ final String sql =
+ "CREATE TABLE derivedTable(\n"
+ + " a INT\n"
+ + ")\n"
+ + "USING CONNECTION mycat.mydb.myconn";
Review Comment:
could you add some tests for malformed connector names .
mycat....mydb....myconn
.
...
.2.2.
""
" "
"😍.😍"
any others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
