ferenc-csaky commented on PR #831:
URL: https://github.com/apache/flink-web/pull/831#issuecomment-4718114724

   > > > > Pls. include the release to the `release_archive.yml` as well. For 
example, check 
[fb6c82d](https://github.com/apache/flink-web/commit/fb6c82db486389a285cb521bc2765e36fa932abb).
   > > > 
   > > > 
   > > > @ferenc-csaky Will do - I will add this to the PR when we release so I 
can put in the correct release date.
   > > 
   > > 
   > > Usually we changed the two files together
   > 
   > I was holding off adding this file to this PR until we have the release 
date which we need for the archive file. So both files will go together in this 
PR. Are ok with this approach otherwise I may put in a potentially inaccurate 
release date that would need amending. The Kafka 5 change is
   > 
   > * name: "Flink Kafka Connector"
   >   connector: "kafka"
   >   version: 5.0.0
   >   release_date: 2026-06-02
   >   filename: "kafka"
   > 
   > So I need an accurate release_date I think.
   > 
   > Have I misunderstood anything?
   
   Correct, but not adding anything may be misinterpreted as forgotten (as i 
did). Personally, I just use TBA as release date when i initially open release 
PRs, so it's clear i plan to update that when the release itself is finalized. 
But that may be personal preference, as long as the final content is okay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to