Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2361#discussion_r97789775
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -80,25 +82,17 @@
// return a factory for empty NFAs
return new NFAFactoryImpl<T>(inputTypeSerializer, 0,
Collections.<State<T>>emptyList(), timeoutHandling);
} else {
+ ArrayList<Pattern<T, ?>> patterns =
createPatternsList(pattern);
--- End diff --
The `patterns` can become a `List` instead of `ArrayList`. It is good to
have the most generic type possible as argument or return type, as
implementations may change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
