Dennis-Mircea commented on code in PR #1099:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1099#discussion_r3426461322
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java:
##########
@@ -259,4 +276,55 @@ void setClock(Clock clock) {
this.metricsCollector.setClock(clock);
this.scalingExecutor.setClock(clock);
}
+
+ @VisibleForTesting
+ protected Tuple2<FlinkAutoscalerEvaluator, Configuration>
getCustomEvaluatorIfRequired(
Review Comment:
Good point. I addressed this. The registry now lives on
`ScalingMetricEvaluator`: it takes the discovered evaluators via its
constructor and resolves the configured one internally. `JobAutoScalerImpl` no
longer references custom evaluators at all (constructor param, field, and
method removed), so the core flow stays minimal. The discovery wiring in
`AutoscalerFactory` / `StandaloneAutoscalerEntrypoint` now feeds `new
ScalingMetricEvaluator(customEvaluators)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
