leonardBang commented on code in PR #4409: URL: https://github.com/apache/flink-cdc/pull/4409#discussion_r3426777039
########## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/source/discover/JdbcTableDiscovererFactory.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cdc.common.source.discover; + +/** + * {@link TableDiscovererFactory} for {@link JdbcTableDiscoverer}. Activated when {@code Review Comment: I grepped the PR branch and the only `TableDiscovererFactory.createDiscoverer(...)` call sites I could find are in `JdbcTableDiscovererITCase`; I could not find any `src/main` caller yet. Because of that, saying this is already activated by `table.discoverer.type = 'jdbc'` reads stronger than the current implementation. Could you either wire this option into the production source creation path in this PR or soften this Javadoc for now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
