davidradl commented on code in PR #28115: URL: https://github.com/apache/flink/pull/28115#discussion_r3427940723
########## flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroVariantDeserializationSchemaTest.java: ########## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.avro; + +import org.apache.flink.connector.testutils.formats.DummyInitializationContext; +import org.apache.flink.formats.avro.generated.Address; +import org.apache.flink.formats.avro.utils.TestDataGenerator; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.table.types.logical.VarCharType; +import org.apache.flink.table.types.logical.VariantType; +import org.apache.flink.types.variant.Variant; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericData; +import org.apache.avro.generic.GenericRecord; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; + +import java.util.Random; + +import static org.apache.flink.formats.avro.utils.AvroTestUtils.fixedRoundRobinSchemaCoderProvider; +import static org.apache.flink.formats.avro.utils.AvroTestUtils.writeRecord; +import static org.assertj.core.api.Assertions.assertThat; + +class AvroVariantDeserializationSchemaTest { + + private static final Address ADDRESS = TestDataGenerator.generateRandomAddress(new Random()); + private static final Schema ADDRESS_SCHEMA = Address.getClassSchema(); + private static final Schema ADDRESS_SCHEMA_V2 = Review Comment: I like the SQL examples - thanks for adding them - they make it a lot clearer. Can we add some more complex examples, - payloads which pick out ROWs that contain ROWs, ARRAYs of ROWS. - Avro schema with dates enums maps unions fixed defaults Then we should document what we do not support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
